Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix space issue in volumePath with vSphere Cloud Provider #38338

Merged
merged 1 commit into from
Dec 8, 2016
Merged

Fix space issue in volumePath with vSphere Cloud Provider #38338

merged 1 commit into from
Dec 8, 2016

Conversation

BaluDontu
Copy link
Contributor

@BaluDontu BaluDontu commented Dec 8, 2016 •
edited

I tried to create a kubernetes deployment with vSphere volume with volume path
"[datastore] kubevols/redis-master".
In this case the cloud provider queries the getDeviceNameFromMount() to return the path of the volume mounted. Since getDeviceNameFromMount() queries the filesystem to get the mount references, it returns a volume path "[datastore]\040kubevols/redis-master". Later the kubelet searches for this volume path in both the actual and desired states. Th actual and desired states contains volume with path "[datastore] kubevols/redis-master". So, it couldn't find such volume path and therefore kubernetes stalls unable to make any progress further similar to one described in #37022.

This PR will fix the space issue in volume path by replacing \040 to empty space. This fixes #37712.
Also fixes #38148
@kerneltime @pdhamdhere

@k8s-ci-robot
Copy link
Contributor

Hi @BaluDontu. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

If you have questions or suggestions related to this bot's behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 8, 2016
@k8s-reviewable
Copy link

This change is Reviewable

@BaluDontu BaluDontu changed the title Fix space in volumePath in vSphere Fix space issue in volumePath with vSphere Cloud Provider Dec 8, 2016
@jingxu97
Copy link
Contributor

jingxu97 commented Dec 8, 2016

@k8s-bot ok to test

@jingxu97 jingxu97 added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Dec 8, 2016
abrarshivani
abrarshivani approved these changes Dec 8, 2016
View reviewed changes
Copy link
Contributor

@abrarshivani abrarshivani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Dec 8, 2016
@kerneltime
Copy link

fixes #38148
fixes #37712

@jingxu97 jingxu97 added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed release-note-label-needed labels Dec 8, 2016
@k8s-github-robot k8s-github-robot added release-note-label-needed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Dec 8, 2016
@jingxu97 jingxu97 added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-label-needed labels Dec 8, 2016
@BaluDontu BaluDontu mentioned this pull request Dec 8, 2016
Closed
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 36310, 37349, 38319, 38402, 38338)

@k8s-github-robot k8s-github-robot merged commit 809d259 into kubernetes:master Dec 8, 2016
@kerneltime kerneltime mentioned this pull request Dec 8, 2016
Merged
@jessfraz jessfraz added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 8, 2016
jessfraz added a commit that referenced this pull request Dec 9, 2016
@jessfraz
Merge pull request #38424 from vmware/automated-cherry-pick-of-#38338…
fc3dd20 
…-kubernetes-release-1.4

Automated cherry pick of #38338
@kerneltime kerneltime mentioned this pull request Jan 11, 2017
Closed
@kerneltime kerneltime mentioned this pull request Jan 11, 2017
Merged
@saad-ali saad-ali added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cherrypick-candidate labels Jan 19, 2017
@saad-ali saad-ali added this to the v1.5 milestone Jan 19, 2017
k8s-github-robot pushed a commit that referenced this pull request Jan 20, 2017
Merge pull request #39757 from vmware/automated-cherry-pick-of-#38338-#…
f4aca2d 
…37413-kubernetes-release-1.5

Automatic merge from submit-queue

Automated cherry pick of #38338 #37413

Cherry pick of #38338 #37413 on release-1.5.

#38338: Fix space in volumePath in vSphere
#37413: Fix for unmount volume to take in volumePath instead of
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.5" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@divyenpatel divyenpatel mentioned this pull request Jul 18, 2017
Closed
@BaluDontu BaluDontu deleted the FixSpaceInVolumePathMaster branch September 5, 2017 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerneltime kerneltime kerneltime approved these changes

@abrarshivani abrarshivani abrarshivani approved these changes

Assignees

@saad-ali saad-ali

@jingxu97 jingxu97

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
10 participants
@BaluDontu @k8s-ci-robot @k8s-reviewable @jingxu97 @kerneltime @k8s-github-robot @k8s-cherrypick-bot @abrarshivani @jessfraz @saad-ali